Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When entering price on QWERTZ NumBlock automagically change/replace "NumBlockComma" to "Fullstop" #330

Open
Cyroex opened this issue Feb 27, 2024 · 5 comments

Comments

@Cyroex
Copy link

Cyroex commented Feb 27, 2024

On QWERTZ keyboards like mine there is a "," (comma) on the numblock but the price input field expects a dot "." (decimal point)
For example: I want to buy DOGE at 200 dollar and 1 cent i enter: "200,01" which should be interpreted as "200.01".

Hope you know what i mean. Thank you.

rr9vqBVYHoGrF1v3crg8

@jaredvu
Copy link
Contributor

jaredvu commented Mar 12, 2024

@Cyroex Thanks for flagging, I think that we can update to handle different decimal separators. Right now, the decimal and thousands separators are determined by locale.

@jaredvu
Copy link
Contributor

jaredvu commented Apr 3, 2024

@moo-onthelawn @aforaleka Do you think we should remove locale handling for these separators and instead have a settings menu to allow users to change to whichever number representation they want?

@Cyroex
Copy link
Author

Cyroex commented May 19, 2024

When i change the interface to "Deutsch" setting in the top menu it works as expected.
But.. boy those translations are rough/confusing/sound like dumb AI/wrong/misleading

Side question: Is it possible to contribute to uk/us (english) -> de/at/ch (german) translation? (one way)

@moo-onthelawn
Copy link
Contributor

hmm @jaredvu, that makes sense, but a bit concerned it would feel too hidden to be discoverable for most users (I feel like the preferences dialog isn't super used). Would be curious to dig into other number representation settings that we might want to configure - if this is the only one, I'm partial to updating number separator handling to be universal across languages ( i.e , and . are interpreted as separators in all languages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants