Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved VFS test coverage #241

Open
fabiospampinato opened this issue Aug 20, 2023 · 0 comments
Open

Improved VFS test coverage #241

fabiospampinato opened this issue Aug 20, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fabiospampinato
Copy link

It looks like js_access, js_truncate and js_print are never actually called when running tests, imo they probably should, to make sure they aren't entirely broken.

The implementation looks correct to me, but more than 0 tests for them would probably be helpful in my opinion.
@dyedgreen dyedgreen added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabiospampinato @dyedgreen