CoinMarketCap-Historical-Prices broken by urllib3 and requests

[NeolithEra]

Hi, users are unable to run CoinMarketCap-Historical-Prices due to dependency conflict with urllib3 package.
As shown in the following full dependency graph of CoinMarketCap-Historical-Prices, CoinMarketCap-Historical-Prices requires urllib3==1.25，while requests==2.21.0 requires urllib3>=1.21.1,<1.25.

According to pip’s “first found wins” installation strategy, urllib3==1.25 is the actually installed version.
However, urllib3==1.25 does not satisfy urllib3>=1.21.1,<1.25.

Dependency tree

CoinMarketCap-Historical-Prices-master
| +-beautifulsoup4(version range:==4.7.1)
| | +-soupsieve(version range:>=1.2)
| +-bs4(version range:==0.0.1)
| | +-beautifulsoup4(version range:*)
| | | +-soupsieve(version range:>=1.2)
| +-certifi(version range:==2018.11.29)
| +-chardet(version range:==3.0.4)
| +-idna(version range:==2.8)
| +-requests(version range:==2.21.0)
| | +-certifi(version range:>=2017.4.17)
| | +-chardet(version range:<3.1.0,>=3.0.2)
| | +-idna(version range:>=2.5,<2.9)
| | +-urllib3(version range:>=1.21.1,<1.25)
| +-urllib3(version range:==1.25)

Thanks for your help.
Best,
Neolith

[NeolithEra]

Solution

Remove your direct dependency urllib3, and use urllib3 transitively introduced by requests.

@dylankilkenny May I submit a PR to solve this issue?

[dylankilkenny]

Yes feel free to make a PR