Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block production not stopping after max_batch_skew #1077

Open
srene opened this issue Sep 17, 2024 · 2 comments · May be fixed by #1140
Open

block production not stopping after max_batch_skew #1077

srene opened this issue Sep 17, 2024 · 2 comments · May be fixed by #1140

Comments

@srene
Copy link
Contributor

srene commented Sep 17, 2024

it only stops after max_batch_skew * batch_submit_bytes, but it does not accumulate batches based on time, i.e. it will not stop after max_batch_skew. * batch_submit_time without submitting batches.

@srene
Copy link
Contributor Author

srene commented Sep 18, 2024

instead of estimating number of batches based on batch size, we could set up a limit based directly on bytes accumulated (e.g. max_batch_skew_bytes), or blocks, to avoid confusion in the config settings. but also we would need to add some sort of notification/alarm for when the sequencer is not submitting on time and it could be slashed based on that.

@omritoptix
Copy link
Contributor

@srene can we close this?

@srene srene linked a pull request Oct 16, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants