Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more verbose error messages on settlement init #344

Closed
omritoptix opened this issue Jun 11, 2023 · 1 comment
Closed

Return more verbose error messages on settlement init #344

omritoptix opened this issue Jun 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@omritoptix
Copy link
Contributor

Currently if not rollapp/sequencer found on init, "key not found" is return. The error should be prefixed by which object exactly was not found by prefixing the err with the reason.

if err != nil {
		if err == ErrBatchNotFound {
			endHeight = 0
		} else {
			return err
		}
	} else {
		endHeight = latestBatch.EndHeight
	}
	b.latestHeight = endHeight
	b.logger.Info("Updated latest height from settlement layer", "latestHeight", endHeight)
	b.sequencersList, err = b.fetchSequencersList()
	if err != nil {
		return err
	}
@omritoptix omritoptix added the enhancement New feature or request label Jun 11, 2023
@mtsitrin
Copy link
Contributor

closed by #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants