-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embed/embed requires v4 requires php 7.4 but i'm using php 8.1 #113
Comments
I guess I should notify someone? @jsirish ^^^ |
Oh better still - the person that did the last update which was a req :) |
It looks like @jsirish has been doing some awesome work updating the block packages to support PHP 8 - it looks like we're almost there, just needs
|
Hey @G-Rath Working through the blocks and PHP 8, have been focusing on the ones we use at Dynamic and the ones downloaded most often. I can look at Customer Service next. We're pretty swamped and have some devs out on vacation so it's been slow going. Appreciate your interest in the blocks! |
@jsirish I saw you updated
Your CI is passing because |
I know jack about |
@jsirish yup that looks like it's resolved it, and I also was able to build against PHP 8.1 too so no dependency blockers there either (my whole app broke, but that's cause I'm not on Silverstripe 4.11 which introduced 8.1 support 😅) Thanks for the quick actioning! |
@G-Rath awesome! I appreciate you guys helping me track down these issues. Feel free to ping here if anything else comes up, we've got a ton of other blocks and modules that I'll be working on as well |
Tried again with SilverStripe 4.11 & PHP 8.1 |
Hi @jsirish, thanks for the updates on the issues regarding PHP8 :) I'm in the process of upgrading some of our Silverstripe projects to 4.11 and PHP 8.1 and we're running into the issue of conflicting version requirements for the embed/embed dependency between Silverstripe framework 4.11 and some of the Elemental Blocks inclusions like dynamic/silverstripe-elemental-oembed and its requirement of Is this currently being investigated or should I open a new ticket? Thanks! |
Hi @lilianasummers - it's a known issue. There is a branch/PR that's currently being tested that resolves the issue. You can do this in composer until it's merged:
|
Hi @lilianasummers, A couple days ago we were able to merge that branch and have released 1.1.0 for the linkable dependency. This should allow you to remove the branch specific reference and update linkable to 1.1.0. |
Upgrading SilverStripe to 4.11 so I can use PHP 8.1
I already have "dynamic/silverstripe-elemental-blocks": "3.0.1"
but SS won't update because silverstripe-elemental-blocks requires a version of embed/embed that I cannot install on PHP 8.1
embed/embed[v4.0.0, ..., v4.2.7] require php ^7.4 -> your php version (8.1.3) does not satisfy that requirement
The text was updated successfully, but these errors were encountered: