Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE better way to hook into sent emails #29

Open
wernerkrauss opened this issue Jul 6, 2023 · 1 comment
Open

FEATURE better way to hook into sent emails #29

wernerkrauss opened this issue Jul 6, 2023 · 1 comment

Comments

@wernerkrauss
Copy link

First, thanks for the great module that gives a good base for a job portal on a website.

When customising this module, it'd be great to

  1. have hooks to configure the email (e.g. programmatically set the email subject with job's name, add files as attachment etc)
  2. have a possibility to send the email from a task for testing/developing

IMHO the mail should be sent either by a method in the JobSubscription class itself or by a seperate method in JobController, that can be extended in an Extension of the controller.

@muskie9
Copy link
Member

muskie9 commented Jul 6, 2023

@wernerkrauss I think the email methodology was brought along from the much earlier iterations of this module and is definitely worth reworking. I think it's worth exploring which location for the method to send would work best, for configuration and extensibility but in any case making it more customizable is something that should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants