Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old Checkpoint files no longer compatible with new firedrake #106

Open
SamAhnert opened this issue Nov 13, 2023 · 2 comments
Open

Old Checkpoint files no longer compatible with new firedrake #106

SamAhnert opened this issue Nov 13, 2023 · 2 comments
Assignees
Labels
bug Something isn't working firedrake priority High-priority core feature

Comments

@SamAhnert
Copy link
Collaborator

SamAhnert commented Nov 13, 2023

I'd like to document that in moving away from pickle (see this commit), the firedrake team rendered data generated and checkpointed on the old version incompatible with the new version if I'm reading this thread correctly.

This renders our tutorial notebooks unusable with the new version of firedrake, and I think the easiest solution is to regenerate the data (especially since pickle is quite fickle with the way it ties itself to versions of packages etc.). I'n not sure how much of a priority we want this to be since it is an issue that would prevent any newcomers from being able to run our tutorials. Not necessarily a bug with the package itself, but this might deter folks interested in HydroGym unfortunately.

@SamAhnert SamAhnert added the bug Something isn't working label Nov 13, 2023
@ludgerpaehler ludgerpaehler self-assigned this Nov 14, 2023
@ludgerpaehler
Copy link
Collaborator

Probably for the best if we regenerate the tutorials tbf (and expand them slightly..)

@SamAhnert
Copy link
Collaborator Author

I agree and we could include loading checkpoints for that (although maybe expanding/refactoring is a separate discussion?). I think that the checkpoints not working is an immediately pertinent issue that's worth addressing in the short-term. I can start running simulations to generate checkpoints.

@ludgerpaehler ludgerpaehler added the priority High-priority core feature label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firedrake priority High-priority core feature
Projects
None yet
Development

No branches or pull requests

2 participants