Add project version CMake CLI variable #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the project version is retrieved from git tags.
This can cause two issues:
Solution
This change adds a project version CMake CLI variable with following syntax
-DPROJECT_VERSION=<project version>
.The user needs to provide
project version
during configuration stage e.g.cmake --preset conan-release -DBUILD_TESTS=OFF -DPROJECT_VERSION=1.0.0
.In GitHub actions
project version
is retrieved from git tags and if no tags are available, commit hash is used.Proof
With
printf("%s\n", PROJECT_VERSION);
added to main.cpp:No
PROJECT_VERSION
variable in the CLI:No
PROJECT_VERSION
value:Wrong version format: