#216 Implement shunt regulation model #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lecourtoisflo
requested review from
gautierbureau,
marcochiaramello and
cossartque
lecourtoisflo
force-pushed
the
216_shunts
branch
2 times, most recently
from
2e65884 to
c349708
Compare
lecourtoisflo
force-pushed
the
216_shunts
branch
from
c349708 to
3cfd0e9
Compare
lecourtoisflo
force-pushed
the
216_shunts
branch
from
3cfd0e9 to
70e1130
Compare
lecourtoisflo
force-pushed
the
216_shunts
branch
from
70e1130 to
d577d00
Compare
marcochiaramello
requested changes
Dec 2, 2021
lecourtoisflo
force-pushed
the
216_shunts
branch
2 times, most recently
from
a5e3e63 to
53fb1cb
Compare
lecourtoisflo
force-pushed
the
216_shunts
branch
from
8333ca5 to
cf400a9
Compare
lecourtoisflo
force-pushed
the
216_shunts
branch
from
cf400a9 to
c57cae4
Compare
marcochiaramello
requested changes
Dec 9, 2021
| } | ||
|
|
||
| const ShuntId id; ///< Shunt id | ||
| const BusId busId; ///< the connected bus of the shunt |
There was a problem hiding this comment.
is this the bus of connection or the regulated one? the comment here is not aligned on the one of line 144 above
There was a problem hiding this comment.
According to dynawo documentation, it is the connection bus (comment l144 corrected)
sources/Inputs/include/Node.h
Outdated
| const BusId busId; ///< the connected bus of the shunt | ||
| const double targetV; ///< the target V of the shunt | ||
| const bool voltageRegulationOn; ///< whether voltage regulation is enabled for the shunt | ||
| const std::vector<double> bSections; ///< the vector of the B values for the shunt |
There was a problem hiding this comment.
please replace B by susceptance everywhere in comments
lecourtoisflo
force-pushed
the
216_shunts
branch
from
1413410 to
7c8b28e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #216
requires dynawo/dynawo#1909