Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors thrown when kernel.ftrace_enabled=0 and things don't work #387

Closed
cormander opened this issue Aug 31, 2014 · 2 comments
Closed

Comments

@cormander
Copy link
Contributor

When I do this;

sudo sysctl kernel.ftrace_enabled=0

There are no errors on kpatch insmod, or on the load of any kpatch modules. The symbols don't get patched either, and yet kpatch doesn't report any problems.

It would be just a simple addition to 4f7c587 if you accept commit, that gets and checks the ftrace_enabled symbol in the same way.

I should note that, after ftrace_bug() is called, this happens:

$ cat /proc/sys/kernel/ftrace_enabled
cat: /proc/sys/kernel/ftrace_enabled: No such device

So we could just replace if (ftrace_disabled) with if (!ftrace_enabled), but I think for sanity sake we ought to check both.

I'm happy to write this if you'd like.

@cormander
Copy link
Contributor Author

7426d53 pushed to my branch ... what can I say? Long weekend.

@jpoimboe
Copy link
Member

jpoimboe commented Sep 2, 2014

Closing for now, see #385 for the current ftrace error handling plan.

@jpoimboe jpoimboe closed this as completed Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants