kpatch_link_object error handling needs work #392
Assignees
Comments
|
@jpoimboe I feel like this is something that I can tackle; mind leaving this to me so you can focus on the harder stuff? |
|
@cormander Sure! There's definitely no shortage of things for us to work on right now... |
|
@cormander Are you actively working on this? If not I'll unassign the issue for now, to leave it open in case anybody else wants to tackle it in the mean time. |
|
|
@cormander Still working on this? |
jpoimboe
added a commit
to jpoimboe/kpatch
that referenced
this issue
Oct 2, 2014
Fix the object unlink error handling so that each function cleans up after itself properly. Also use find_symbol() instead of __symbol_get() to make cleanup easier. When patching a module we don't need a reference to each symbol, since we already have done a try_module_get() on the module. Fixes dynup#392.
jpoimboe
added a commit
to jpoimboe/kpatch
that referenced
this issue
Oct 4, 2014
Fix the object unlink error handling so that each function cleans up after itself properly. Also use find_symbol() instead of __symbol_get() to make cleanup easier. When patching a module we don't need a reference to each symbol, since we already have done a try_module_get() on the module. Fixes dynup#392.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As reported in #384, the
kpatch_link_object()error handling is all kinds of wrong and could result in improper calls tokpatch_ftrace_remove_func()and__symbol_put().The text was updated successfully, but these errors were encountered: