Skip to content

Latest commit

 

History

History
177 lines (107 loc) · 3.05 KB

converting_c_to_java.md

File metadata and controls

177 lines (107 loc) · 3.05 KB
Raw
  • if( 0 != ...

if(0 != (cmd & Cmd.CMD_AUTO))

byte -> int

  • clever use of ,
( bonus += 10, age > 10 ) ||
( bonus += 20, age > 5 ) ||
( bonus += 40, age > 2 ) ||
( bonus += 100, true )
  • idiotic use of ,
		//if (!tile.IsTileType(TileTypes.MP_RAILWAY) || ((dir = 0, tile.getMap().m5 != 1) && (dir = 1, _tile.getMap().m5 != 2)))
		//	return Cmd.return_cmd_error(Str.STR_1005_NO_SUITABLE_RAILROAD_TRACK);

		if (!tile.IsTileType(TileTypes.MP_RAILWAY))
			return Cmd.return_cmd_error(Str.STR_1005_NO_SUITABLE_RAILROAD_TRACK);

		if(tile.getMap().m5 == 1)
			dir = 0;
		else if(_tile.getMap().m5 == 2)
			dir = 1;
		else
			return Cmd.return_cmd_error(Str.STR_1005_NO_SUITABLE_RAILROAD_TRACK);
  • simple pointers -> one el arrays
modify( int[] x )
{
  x[0]++;
}
  • Pointer or allocated local object
NPFFindStationOrTileData fstd;
...
NPFFillWithOrderData(&fstd, v);

must be

NPFFindStationOrTileData fstd = new NPFFindStationOrTileData();
...
NPFFillWithOrderData(fstd, v);
  • No enums

if( flags & FLG_USED ) does not work on Java enums use constants and ints

  • no macros
BitOps.SB(tile.getMap().m2, 0, 4, new_ground);

to

tile.getMap().m2 = BitOps.RETSB(tile.getMap().m2, 0, 4, new_ground);
  • bad replacements

'finalruct' was 'construct' initially

  • unsigneds

Integer. and Long. have operations needed

  • и одним движением брови уничтожил вю мою кунсткамеру

allocations - draw lists / semi/automatic variables and per-draw allocator

  • boolean value used as int - is boolean->int value standard?

  • int used as boolean

  • java decl does not create object itself = bunch of null ptr accesses

  • unsigned problems - negatives where they'r not assumed to be and vice versa

a lot of 16 bit integers in original game, all become unsigneds when load from data files

  • hack it!

v->progress is unit16

static bool ShipAccelerate(Vehicle *v)
{
	uint spd;
	byte t;

	spd = min(v->cur_speed + 1, v->max_speed);

	//updates statusbar only if speed have changed to save CPU time
	if (spd != v->cur_speed) {
		v->cur_speed = spd;
		if (_patches.vehicle_speed)
			InvalidateWindowWidget(WC_VEHICLE_VIEW, v->index, STATUS_BAR);
	}

	// Decrease somewhat when turning
	if (!(v->direction & 1)) spd = spd * 3 / 4;

	if (spd == 0) return false;
	if ((byte)++spd == 0) return true;

	v->progress = (t = v->progress) - (byte)spd;

	return (t < v->progress);
}


	static boolean ShipAccelerate(Vehicle v)
	{
		int spd;
		int t; // was unsigned byte

		spd = Math.min(v.cur_speed + 1, v.max_speed);

		//updates statusbar only if speed have changed to save CPU time
		if (spd != v.cur_speed) {
			v.cur_speed = spd;
			if (Global._patches.vehicle_speed)
				Window.InvalidateWindowWidget(Window.WC_VEHICLE_VIEW, v.index, STATUS_BAR);
		}

		// Decrease somewhat when turning
		if (0 ==(v.direction & 1)) spd = spd * 3 / 4;

		if (spd == 0) return false;
		if (++spd == 0) return true;

		t =  v.progress & 0xFF;
		v.progress = BitOps.uint16Wrap( t - spd );

		return (t < v.progress);
	}