Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing the dropdown when clicking outside of it #7

Open
dzhavat opened this issue Dec 24, 2018 · 2 comments
Open

Closing the dropdown when clicking outside of it #7

dzhavat opened this issue Dec 24, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dzhavat
Copy link
Owner

dzhavat commented Dec 24, 2018

Right now, the only way to close the dropdown list is by clicking again on the button.

demo

It'd be nice if the dropdown could close when clicking outside of it. That'd also make it behave similarly to all other dropdowns on GitHub.
@dzhavat dzhavat added enhancement New feature or request good first issue Good for newcomers labels Dec 24, 2018
@fregante
Copy link
Contributor

fregante commented Dec 29, 2018 •
edited
Loading

This is best implemented by copying the native <details> implementation that other GitHub buttons have. You can copy the whole Filter dropdown and also fix this other issue in one go: #8

@dzhavat
Copy link
Owner Author

dzhavat commented Dec 29, 2018

Nice! Will give it a try 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dzhavat @fregante