Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix icon display error in qq miniprogram #213

Closed
wants to merge 1 commit into from
Closed

fix: fix icon display error in qq miniprogram #213

wants to merge 1 commit into from

Conversation

Topology2333
Copy link
Contributor

close #210

lin594
lin594 requested changes Apr 13, 2024
View reviewed changes
.github/workflows/receive-pr.yml Outdated
run: |
npm install
npm cache clean --force
npm audit fix --force
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我一点也不能理解你的逻辑，你不应该强制修复之后提交更改嘛？为什么是在workflow里写

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你说的是 package.json 吧，我今天又检查了一下，我发现如果是 build 就会出错，但是用 dev 编译出来的就是正常的，所以我最新的代码改成了 dev

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

而且只改 package.json 目前来看没法解决这个问题（）

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build 和 dev 他的编译逻辑是不一样的，不能简单把dev换成build来解决这个问题

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

但是按这里的说法，dev 也是可以用的，只不过有断点、压缩、process.env.NODE_ENV的区别……
况且本机选择 dev 编译出来的玩意确确实实是可以运行的，即使把 dev 的 process 关了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得我应该在 dev 的编译完成后把这个进程关了，这样应该就没什么问题了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那还得改一些别的东西， 还是小小钻研一下为什么有这个区别）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

行

@Topology2333 Topology2333 force-pushed the fix-qq-build branch 2 times, most recently from f998c66 to 3abdc0f Compare April 13, 2024 13:15
@lin594 lin594 closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lin594 lin594 lin594 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QQ小程序兼容度检查
2 participants
@Topology2333 @lin594