Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group related settings in some nested struct #2236

Open
richardebeling opened this issue Jul 1, 2024 · 0 comments
Open

Group related settings in some nested struct #2236

richardebeling opened this issue Jul 1, 2024 · 0 comments
Labels
Attempt This might turn out to be not (easily) implementable. In this case we'll probably close the issue. [C] Backend Focuses on backend implementation [P] Nice to have Lowest priority. Some people might use this feature but it won't have a big impact. [S] Small This issue should require only small changes.

Comments

@richardebeling
Copy link
Member

We have some settings that could be grouped/nested, e.g.

  • the importer settings
  • the oidc settings (although these are probably forced by mozilla-django-oidc?)
  • possibly the global rewards settings
  • the result computation settings
  • SLOGANS_EN and SLOGANS_DE would probably make sense to have as a dictionary (language-str, list[str])

The biggest problem probably is allowing to still use override_settings for nested settings as well.
@richardebeling richardebeling added [C] Backend Focuses on backend implementation [S] Small This issue should require only small changes. Attempt This might turn out to be not (easily) implementable. In this case we'll probably close the issue. labels Jul 1, 2024
@richardebeling richardebeling mentioned this issue Jul 1, 2024
Merged
5 tasks
@janno42 janno42 added the [P] Nice to have Lowest priority. Some people might use this feature but it won't have a big impact. label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Attempt This might turn out to be not (easily) implementable. In this case we'll probably close the issue. [C] Backend Focuses on backend implementation [P] Nice to have Lowest priority. Some people might use this feature but it won't have a big impact. [S] Small This issue should require only small changes.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janno42 @richardebeling