Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density in density.txt is taken at 1 bar, not at 1.01325 bar #654

Open
lyphrowny opened this issue Oct 9, 2024 · 0 comments · May be fixed by #670
Open

Density in density.txt is taken at 1 bar, not at 1.01325 bar #654

lyphrowny opened this issue Oct 9, 2024 · 0 comments · May be fixed by #670
Labels
bug Something isn't working

Comments

@lyphrowny
Copy link

lyphrowny commented Oct 9, 2024

Describe the bug
All the density values listed in src/pandapipes/properties/<gas_name>/density.txt are stored at 1 bar (see example file: link). The formula that converts gas density at normal conditions, uses 1.01325 bar (NORMAL_PRESSURE) in its denominator. This inconcistency arises because the density from fluid.get_denstity() is returned at 1 bar. As a result, this leads to a 1.3% error in converting gas density from normal conditions.

Expected behavior
There should be consistency in normal conditions. I guess, the proper way to achieve this is to store gases' densities at 1.01325 bar

Python environment:

@lyphrowny lyphrowny added the bug Something isn't working label Oct 9, 2024
@jkisse jkisse linked a pull request Dec 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant