Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit default output writer #651

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

harrahx3
Copy link

Remove the results from source, sink and ext_grid from the default OutputWriter and edit the testing accordingly, because cannot assume that the network will contain these elements.

I was running a timeseries calculation with a District Heating Network, which has no source, sink and ext_grid and figured out that I need to explicitly defined an OutputWriter as the default one assume that these elements are present in the network.

It seems safe to assume that junctions and pipes are always part of the network though.

Copy link
Collaborator

@dlohmeier dlohmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Pull Request. You are absolutely right that it is not quite logical to assume that a default pandapipes output write must include sinks, sources and ext_grids. I just think that we should do the following as well:

  1. Make sure that an output writer neglects logging variables to be added in case the table does not exist (you might add an enforce argument)
  2. Small auxiliary functions to add logging variables for gas and heating networks.

Is it possible for you to add to this PR? Otherwise, we have to add this to our schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants