Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing optional dependencies / documentation for used packages #2468

Open
KS-HTK opened this issue Nov 29, 2024 · 0 comments
Open

Missing optional dependencies / documentation for used packages #2468

KS-HTK opened this issue Nov 29, 2024 · 0 comments

Comments

@KS-HTK
Copy link
Collaborator

KS-HTK commented Nov 29, 2024

Issue

When using simple_plotly with the on_map parameter there is a function call to validate that the geodata is in fact on the map, it uses geopy to do this. geopy is not in the dependencies/optional dependencies for pandapower.

For this case the docs also make no mention that geopy might be used/required by simple_plotly.

I think all used dependencies should at least be listed once in any of the optional dependency categories, and should appear under the all keyword if they are called by pandapower code. Implicite requirements might break if the dependency that requires that package might remove it from there dependencies at any time.

How is this currently handled? Is there a preferred method, as this is not the only package I found that is not listed anywhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant