From 59da2df7b201f7b3f05d9ecb6e01c7311563caed Mon Sep 17 00:00:00 2001
From: Bryce Buchanan <75274611+bryce-b@users.noreply.github.com>
Date: Tue, 3 Dec 2024 09:22:31 -0800
Subject: [PATCH] [Cypress] Transaction details tests fix (#199391)

## Summary
This PR re-enables the Transaction details cypress test, which was
disabled due to flakiness. The majority of the tests in this file needed
an increased timeout to run correctly. However, the 'Show top errors
table' test remains disabled, because it will consistently fail in
buildkite executing `.contains('a', '[MockError] Foo')`. This is
unreproducible locally, and no amount of refactoring or re-configuring
seems to affect the outcome.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
---
 .../e2e/transaction_details/transaction_details.cy.ts | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts
index af23fc8a2ad7e..0ef8fb40ceb38 100644
--- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts
+++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts
@@ -15,8 +15,7 @@ const timeRange = {
   rangeFrom: start,
   rangeTo: end,
 };
-// flaky
-describe.skip('Transaction details', () => {
+describe('Transaction details', () => {
   before(() => {
     synthtrace.index(
       opbeans({
@@ -34,7 +33,7 @@ describe.skip('Transaction details', () => {
     cy.loginAsViewerUser();
   });
 
-  it('shows transaction name and transaction charts', () => {
+  it('shows transaction name and transaction charts', { defaultCommandTimeout: 60000 }, () => {
     cy.intercept('GET', '/internal/apm/services/opbeans-java/transactions/charts/latency?*').as(
       'transactionLatencyRequest'
     );
@@ -60,7 +59,7 @@ describe.skip('Transaction details', () => {
         '@transactionThroughputRequest',
         '@transactionFailureRateRequest',
       ],
-      { timeout: 30000 }
+      { timeout: 60000 }
     ).spread((latencyInterception, throughputInterception, failureRateInterception) => {
       expect(latencyInterception.request.query.transactionName).to.be.eql('GET /api/product');
 
@@ -106,7 +105,9 @@ describe.skip('Transaction details', () => {
     );
     cy.contains('Create SLO');
   });
-  it('shows top errors table', () => {
+
+  // flaky
+  it.skip('shows top errors table', () => {
     cy.visitKibana(
       `/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({
         ...timeRange,