Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HO to enable taking app memory size from SM input #263

Open
yamingk opened this issue Feb 26, 2025 · 0 comments
Open

HO to enable taking app memory size from SM input #263

yamingk opened this issue Feb 26, 2025 · 0 comments

Comments

@yamingk
Copy link
Contributor

yamingk commented Feb 26, 2025

I believe we should fix this: https://github.com/eBay/HomeObject/blob/main/src/lib/homestore_backend/hs_homeobject.cpp#L125
Ideally the app_mem_size should come from SM booting parameter by consulting the pod spec Memory Limit.

Maybe something like:

class HomeObjectApplication { 
...
    virtual uint64_t app_mem_size() const = 0; // >>>> SM will implement this while instantialize HomeObject.
...
}

void HSHomeObject::init_homestore() {
...
    const uint64_t app_mem_size = app->app_mem_size();
...
}

Slack Discussion.
https://ebay-eng.slack.com/archives/CAVQXEAKS/p1739472960517899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant