Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pagination): change default number of pages shown #2238

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix(pagination): change default number of pages shown #2238

merged 3 commits into from
Sep 19, 2024

Conversation

LuLaValva
Copy link
Member

Description

  • Pagination currently defaults to show every page during initial render and then decreases after a page width is found. This seems reasonable at first glance, but it is problematic when there is a large number of pages and the component is rendered on the server.

Context & Screenshots

  • See attached issue

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: bcabea7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva self-assigned this Aug 27, 2024
@LuLaValva LuLaValva changed the base branch from master to 14.2.0 August 27, 2024 15:57
agliga
agliga requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting some test failures

Base automatically changed from 14.2.0 to master August 30, 2024 16:24
@LuLaValva LuLaValva changed the base branch from master to 14.3.0 September 19, 2024 20:06
@LuLaValva
Copy link
Member Author

Bonus change: Test failures are reported in a __screenshots__ directory, which should never be committed, so I added to .gitignore

@agliga agliga merged commit cd855f1 into 14.3.0 Sep 19, 2024
4 checks passed
@agliga agliga deleted the 2235-pagination-ssr branch September 19, 2024 21:35
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Closed
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agliga agliga agliga approved these changes

@ArtBlue ArtBlue Awaiting requested review from ArtBlue

Assignees

@LuLaValva LuLaValva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ebay-pagination: shorten default number of items
2 participants
@LuLaValva @agliga