-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate this package in favor of eslint:recommended #18
Comments
austingardner
changed the title
eslint-config-ebay has been neglected.. should we keep it or just use recommended?
eslint-config-ebay has been neglected.. should we keep it or just use eslint:recommended?
Jul 17, 2021
Your question makes sense, I have seen this kind of configuration in {
"extends": [
"ebay",
"plugin:testing-library/recommended",
"plugin:jest/recommended"
],
"parserOptions": {
"ecmaVersion": 2020, // eslint-config-ebay uses 2017 which has this issue - https://github.com/eBay/eslint-config-ebay/issues/13
"sourceType": "module" // To accommodate ES module imports
},
"overrides": [
{
"files": "**/test/**/*.browser.js",
"extends": ["plugin:jest-dom/recommended"] // We want jest-dom recommended styles only for browser tests as some of the jest-dom helpers are not available in server tests.
},
{
"files": "**/test/mock-data/**/*.js", // Disable few rules for mock data
"rules" : {
"max-len": "off"
}
}
],
"globals": {
"GH": "readonly"
}
} IMHO we should apply on top of this project community recommendations. |
ianmcburnie
changed the title
eslint-config-ebay has been neglected.. should we keep it or just use eslint:recommended?
Deprecate this package in favor of eslint:recommended
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems this repo hasn't had many updates for a long time. Should we keep it or should we just use a different set of rules?
At least we should upgrade the eslint version and set
So we can use the latest ecmascript versions.
The text was updated successfully, but these errors were encountered: