Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

230810 - Item tile framework and components #2133

Open
ratinsl opened this issue Aug 10, 2023 · 6 comments
Open

230810 - Item tile framework and components #2133

ratinsl opened this issue Aug 10, 2023 · 6 comments

Comments

@ratinsl
Copy link

ratinsl commented Aug 10, 2023

230810_Item_Tiles

DS has constructed a new item tile framework and would like to partner with the skin team in building out item tile components.
Below you will find links to the KO item tile framework deck we shared, as well as the updated documentation page.

Please reach out to Jeremy and I with any questions.

Best,
Ryan

@agliga
Copy link
Contributor

agliga commented Jan 19, 2024

Need to verify if we can use grid layout to align the title and price elements.

@agliga agliga added this to the 17.4.0 milestone Mar 21, 2024
@agliga agliga modified the milestones: 17.4.0, 17.5.0 Apr 15, 2024
@ArtBlue
Copy link
Contributor

ArtBlue commented Apr 19, 2024

I verified that display: grid can be used with grid-template-areas "cells" to accomplish the layout. The most flexible layout appears to be an outer flex for the item tiles and a grid display for each item tile.

The solution will involve something along the lines of:

grid-template-rows: auto 25px 60px 1fr;
grid-template-areas:
    "image"
    "signal"
    "title"
    "highlight";

image

@ArtBlue
Copy link
Contributor

ArtBlue commented May 6, 2024

@ratinsl , I'm punting this for now. The DS specs are not feasible in some instances and they generally need to be more responsive-centric and less pixel-prescriptive. We can discuss offline.

@ArtBlue ArtBlue modified the milestones: 17.5.0, 18.0.0 May 6, 2024
@agliga agliga modified the milestones: 18.0.0, 18.1.0 May 14, 2024
@agliga agliga modified the milestones: 18.1.0, 18.2.0 Jun 27, 2024
@ArtBlue
Copy link
Contributor

ArtBlue commented Jun 27, 2024

Hey, @ratinsl , to start this issue, we'll need the number of item tiles to display per row before wrapping to next line. Once those specs are defined, we can start this. This is related to the discussion we had previously about responsive elements that repeat. The minimum and maximum widths of the item tiles should also not block the item tiles from being fluid enough with the rules you put in place.

@randybascue
Copy link

I'm assuming we can update the specs to match the toggle button. I can try helping there.

@ArtBlue
Copy link
Contributor

ArtBlue commented Jun 28, 2024

I'm assuming we can update the specs to match the toggle button. I can try helping there.

Thanks, @randybascue . Yes, it would be similar to what you did with toggle-button-group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants