Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notice: rework footer and cta sections #2146

Open
ianmcburnie opened this issue Sep 1, 2023 · 1 comment
Open

notice: rework footer and cta sections #2146

ianmcburnie opened this issue Sep 1, 2023 · 1 comment

Comments

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Sep 1, 2023

CTA should be positioned under body on small screen in all cases, even when there is no dismiss button:
Screenshot 2023-09-01 at 11 30 19 AM

We can see that when there is a CTA with dismiss button, the CTA is positioned correctly.

Screenshot 2023-09-01 at 11 26 41 AM

When we replace the dismiss button with the CTA, the CTA loses the ability to go in the correct space under the body:
Screenshot 2023-09-01 at 11 26 30 AM

Even if trying to use just the section-notice__cta (not sure if this is the desired expectation - it is not clear from current docs or stories), there is a spacing issue on large screens:

Screenshot 2023-09-01 at 11 36 57 AM

This behavior can be verified in current storybook: https://opensource.ebay.com/skin/storybook/?path=/story/skin-section-notice--information-with-button

@agliga
Copy link
Contributor

agliga commented Sep 19, 2023

We should rework notice, this should be done for all notices. We should rework cta/footer as well as in ebayui.

@agliga agliga assigned agliga and unassigned saiponnada Nov 16, 2023
@agliga agliga removed this from the 17.0.0 milestone Dec 21, 2023
@agliga agliga added this to the 18.0.0 milestone Apr 29, 2024
@agliga agliga assigned ArtBlue and unassigned ianmcburnie and agliga May 22, 2024
@agliga agliga removed this from the 18.0.0 milestone Jun 21, 2024
@agliga agliga added the size: 2 label Aug 21, 2024
@agliga agliga changed the title Section-Notice: issues with CTA only variant notice: rework footer and cta sections Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants