You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I verified there's no existing issue for this bug.
There are no existing issues
Current behavior
icon-button currently has a negative outline-offset: outline-offset: -10px;...
The modules that use it have to resort to creating overrides to utilize it properly.
Expected behavior
Ideally, there should be no negative offset and except in the rarest of cases. Modules should be able to use icon-button with its modifiers to achieve the desired effect.
Skin version
17.3.0
Device/OS/Browser info
(all)
Steps to reproduce
1. (See details)
Relevant code block
Investigate why the negative offset was added in the first place and understand the intent. The negative offset may be needed elsewhere for a more specific use. If so, move it and scope it inside only where needed, if at all.
Remote the negative offset.
Remove the overrides in other modules that use icon-button and see how they each look.
Make small adjustments as needed in each module.
Additional context
No response
The text was updated successfully, but these errors were encountered:
We need to remove all custom outline offsets and then for transparent modifier to add a custom outline offset so it does not focus on the padding/border area but directly on the icon.
I verified there's no existing issue for this bug.
Current behavior
icon-button
currently has a negative outline-offset:outline-offset: -10px;
...The modules that use it have to resort to creating overrides to utilize it properly.
Expected behavior
Ideally, there should be no negative offset and except in the rarest of cases. Modules should be able to use
icon-button
with its modifiers to achieve the desired effect.Skin version
17.3.0
Device/OS/Browser info
(all)
Steps to reproduce
Relevant code block
icon-button
and see how they each look.Additional context
No response
The text was updated successfully, but these errors were encountered: