Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Education notice: update background color #2370

Closed
4 of 6 tasks
randybascue opened this issue Jul 2, 2024 · 0 comments
Closed
4 of 6 tasks

Education notice: update background color #2370

randybascue opened this issue Jul 2, 2024 · 0 comments
Assignees
Milestone

Comments

@randybascue
Copy link

Description

Problem

The --color-background-education variable is currently a hard-coded hex value. This value arose due to not having a core value available that matched the proposed design.

Solution

Update --color-background-education to match the latest design specs.

Light theme

--color-background-education: --color-core-blue-100

Dark theme

--color-background-education: --color-core-indigo-800

Acceptance criteria

The --color-background-education value is updated to the latest spec for dark and light theme.

Screenshots

No response

Figma link

https://www.figma.com/design/zEBdEhbonrBOGzZ0fXzWvM/eBay-Design-System?node-id=90732-97759&t=xR7sXv0VafH47Rw2-11

Engineering pre-requisites

  • Successful design review with Design System Team.
  • Supports dark mode.
  • Supports responsive design.
  • Tokens have been provided (or already exist).
  • Successful accessibility review with Core A11Y Team.
  • Successful frontend review with eBayUI Team.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants