Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: code highlight style doesn't display properly in dark mode #2372

Closed
1 task done
cordeliadillon opened this issue Jul 3, 2024 · 0 comments
Closed
1 task done

Comments

@cordeliadillon
Copy link
Contributor

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

The .highlight CSS class used in the Skin docs is difficult to see in dark mode. While the text color changes between light and dark modes, the background color stays fixed, resulting in white on light grey in dark mode:

Light mode

Screenshot 2024-07-02 at 17 30 43

Dark mode

Screenshot 2024-07-02 at 17 30 26

Expected behavior

Background color should change to a more suitable color, w/ 4.5:1 contrast ratio against foreground color

Skin version

No response

Device/OS/Browser info

No response

Steps to reproduce

1. Set your system color mode to "Dark"
2. Browse https://opensource.ebay.com/skin/

Relevant code block

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants