Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Incorrect C++ includes generated for IDLs which include enum-only IDLs #215

Closed
clunietp opened this issue Aug 31, 2023 · 1 comment
Closed

Comments

@clunietp
Copy link

Consider the following:

MyEnums.idl:

module foo {
    enum Bar {
        SOME_VALUE
    }
}

MyMessage.idl:

#include "MyEnums.idl"
module foo {
    struct MyMessage {
            foo::Bar myValue;
    }
}

Using Fast-DDS-Gen v2.5 (omitting -o option) results in the following cpp code for MyMessage.idl:

...
#include "MyEnumsPubSubTypes.h"
...

However, because MyEnums.idl only defines enums, the MyEnumsPubSubTypes.h file is never generated by Fast-DDS-Gen, leading to an invalid include directive in the generated cpp file for MyMessage.h (and/or MyMessagePubSubTypes.h; I'm working from memory).

This appears to be a regression in Fast-DDS-Gen v2.5. Version 2.4 is handling this properly.

@JLBuenoLopez
Copy link
Contributor

Thanks for your report, @clunietp

#212 fixed the issue you mention in master and it is going to be formally released in the coming weeks. I am going to close the issue as it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants