[20739] Refactor IStatusQueryable and make monitor service interfaces private #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eryable) Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
12 tasks
Signed-off-by: Mario Dominguez <[email protected]>
|
@richiprosima please test this |
Signed-off-by: Mario Dominguez <[email protected]>
JLBuenoLopez
suggested changes
Apr 5, 2024
Signed-off-by: Mario Dominguez <[email protected]>
|
@richiprosima please test this |
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
requested review from
JLBuenoLopez
and removed request for
JLBuenoLopez
|
@richiprosima please test this |
Signed-off-by: Mario Dominguez <[email protected]>
8 tasks
|
I'm seeing the same Github Windows errors in nightlies and other PR and seem to have something to do with the runners infra, so I'm merging this one. |
|
@Mergifyio backport 2.13.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
…#4651) * Refs #20739: Make monitor service interfaces private (except IProxyQueryable) Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Replace tabs with spaces in monitorservice_types.idl Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Refactor include and src files Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Refactor tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Apply suggestion regarding asserts Signed-off-by: Mario Dominguez <[email protected]> * Refs 20739: Rev 2 changes Signed-off-by: Mario Dominguez <[email protected]> * Refs 20739: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs 20739: Rev 3 changes Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Remove status assert Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Comment typo Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit fb841b9) # Conflicts: # include/fastdds/rtps/reader/RTPSReader.h # include/fastdds/rtps/writer/RTPSWriter.h
This was referenced Apr 17, 2024
[20739] Refactor IStatusQueryable and make monitor service interfaces private (backport #4651)
#4687
Merged
EduPonz
pushed a commit
that referenced
this pull request
May 24, 2024
…#4651) (#4687) * Refactor IStatusQueryable and make monitor service interfaces private (#4651) * Refs #20739: Make monitor service interfaces private (except IProxyQueryable) Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Replace tabs with spaces in monitorservice_types.idl Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Refactor include and src files Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Refactor tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Apply suggestion regarding asserts Signed-off-by: Mario Dominguez <[email protected]> * Refs 20739: Rev 2 changes Signed-off-by: Mario Dominguez <[email protected]> * Refs 20739: Linter Signed-off-by: Mario Dominguez <[email protected]> * Refs 20739: Rev 3 changes Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Remove status assert Signed-off-by: Mario Dominguez <[email protected]> * Refs #20739: Comment typo Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit fb841b9) # Conflicts: # include/fastdds/rtps/reader/RTPSReader.h # include/fastdds/rtps/writer/RTPSWriter.h * Fix conflicts based on original PR Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> Co-authored-by: Mario Domínguez López <[email protected]> Co-authored-by: JesusPoderoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings to
masterthe work from #4640 commit a2f4664 and 7a0c328. It refactors theIStatusQueryable()interface and make monitor service interfaces private (except fromIProxyQueryable.hppasPDP.his still public inmasterand implements it).@Mergifyio backport 2.13.x
Contributor Checklist
versions.mdfile (if applicable).Related documentation PR: [20739] Remove ddsentitystatus from docs Fast-DDS-docs#745
Reviewer Checklist