Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates:each creates wrapping element #18

Open
line-o opened this issue Feb 20, 2017 · 2 comments
Open

templates:each creates wrapping element #18

line-o opened this issue Feb 20, 2017 · 2 comments
Assignees
Labels

Comments

@line-o
Copy link
Member

line-o commented Feb 20, 2017

Applies to current shared-resources v0.4.0.

The example from http://exist-db.org/exist/apps/demo/examples/templating/templates.html
does wrap all <tr> elements in a <tr>.

Replacing %templates:wrap with %templates:replace solves the issue.

The current version of templates.xql does not seem to have this problem but is not released yet.

@joewiz
Copy link
Member

joewiz commented Aug 8, 2018

This issue states that the problem had already been fixed in source but just wasn't released yet. There have been releases since then, so the fix was surely included.

@line-o Please reopen if I'm incorrect.

@joewiz joewiz closed this as completed Aug 8, 2018
@joewiz joewiz reopened this Dec 19, 2019
@joewiz joewiz self-assigned this Dec 19, 2019
@joewiz joewiz added the bug label Dec 19, 2019
@joewiz
Copy link
Member

joewiz commented Dec 19, 2019

This problem indeed remains in source. The cause was https://github.com/eXist-db/shared-resources/pull/29/files#diff-7f941bbe6a7334081fb7678dc7e71b99R451-R453 - adapted from https://github.com/eXist-db/shared-resources/pull/27/files#diff-7f941bbe6a7334081fb7678dc7e71b99R459-R461. However, the solution shouldn't be to change %templates:wrap to %templates:replace, since replace is not a supported or documented annotation. The solution is to remove the %templates:wrap annotation. I'll investigate if any other items deleted in that PR should be reinstated, and I'll submit a PR.

joewiz added a commit to HistoryAtState/hsg-shell that referenced this issue Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants