From c3d55a0a0fd9610cbfbd80d53efb72d20ee3faa4 Mon Sep 17 00:00:00 2001
From: ea4k <jaime@robles.es>
Date: Thu, 15 Aug 2024 17:44:12 +0200
Subject: [PATCH] Subdivisions are not repeated in combobox

---
 src/database/db_adif_primary_subdvisions_data.cpp | 2 +-
 src/inputwidgets/mainwindowinputothers.cpp        | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/database/db_adif_primary_subdvisions_data.cpp b/src/database/db_adif_primary_subdvisions_data.cpp
index 80a6f965..147da202 100644
--- a/src/database/db_adif_primary_subdvisions_data.cpp
+++ b/src/database/db_adif_primary_subdvisions_data.cpp
@@ -131,7 +131,7 @@ bool DB_ADIF_Primary_Subdvisions_data::add_Canada_1()
         << "'1', 'New Brunswick', 'NB', 'VE9', '05', '09', '', '-1', '', '', 'N'"
         << "'1', 'New foundland', 'NL', 'VO1', '02', '09', '', '-1', '', '', 'N'"
         << "'1', 'New foundland', 'NL', 'VO1', '05', '09', '', '-1', '', '', 'N'"
-        << "'1', 'Yukon', 'YT', 'vy1', '01', '02', '', '-1', '', '', 'N'"
+        << "'1', 'Yukon', 'YT', 'VY1', '01', '02', '', '-1', '', '', 'N'"
         << "'1', 'Prince Edward island', 'PE', 'VY2', '05', '09', '', '-1', '', '', 'N'"
         << "'1', 'Nunavut', 'NU', 'VY0', '02', '04', '', '-1', '', '', 'N'"
         << "'1', 'Nunavut', 'NU', 'VY0', '02', '09', '', '-1', '', '', 'N'"
diff --git a/src/inputwidgets/mainwindowinputothers.cpp b/src/inputwidgets/mainwindowinputothers.cpp
index 3a7bd671..873ff8b2 100644
--- a/src/inputwidgets/mainwindowinputothers.cpp
+++ b/src/inputwidgets/mainwindowinputothers.cpp
@@ -744,10 +744,16 @@ void MainWindowInputOthers::updatePrimarySubdivisionsComboBox(QList<PrimarySubdi
 
     QStringList listOfSubdivisions;
     listOfSubdivisions.clear();
+    QStringList names;
+    names.clear();
+
+
     foreach (PrimarySubdivision ps, _subdivisions)
     {
+
         QString subdivision = ps.shortName + "-" + ps.name;
-        listOfSubdivisions.append(subdivision);
+        if (!listOfSubdivisions.contains(subdivision))
+            listOfSubdivisions.append(subdivision);
         //qDebug() << Q_FUNC_INFO << ": Subdivision added: " << subdivision;
     }
     if (listOfSubdivisions.count()<1)