Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add “GB” in the print information? #45

Open
qiuxin opened this issue Jul 8, 2020 · 1 comment
Open

Add “GB” in the print information? #45

qiuxin opened this issue Jul 8, 2020 · 1 comment

Comments

@qiuxin
Copy link

qiuxin commented Jul 8, 2020

Hi There,
Would suggest adding AvailCapacity, TestedCapacity, TestedOffset in GB in RunAllTests function. That would be compatible with "NVMe list" Command. NVMe List adopts GB instead of GiB. I would like to submit a patch if you agree.

print(fmtinfo.format("AvailCapacity", str(physDriveGiB) + " GiB"))
print(fmtinfo.format("TestedCapacity", str(testcapacity) + " GiB"))
print(fmtinfo.format("TestedOffset", str(testoffset) + " GiB"))

Best,
Robert Q

@earlephilhower
Copy link
Owner

Is there a particular reason you're thinking about changing this? I think it needs more than just an output change to go from GiB->GB, so might be kind of tedious.

I believe the FIO command line would need changing (i.e. offset from the cmd line would now be in GB and not GiB, so the scale factor would need to be adjusted and properly aligned....maybe other spots, too).

You'd also then have the situation where you're reporting size in GB, but bandwidth in GiB/s (and IIRC FIO has a kind of backwards naming of them in config and output).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants