Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mocks in tests for external github API calls #194

Open
kcranston opened this issue Mar 12, 2020 · 1 comment
Open

use mocks in tests for external github API calls #194

kcranston opened this issue Mar 12, 2020 · 1 comment
Assignees
Labels

Comments

@kcranston
Copy link
Collaborator

There are several places in the code where we call github via the API. This code has no test coverage right now (to avoid calling the API each time we run the test suite and running into API rate limits). Ideally, we would mock the github response and / or local changes in tests that include a github call. This includes any code that calls the following methods in github.py:

@lwasser
Copy link

lwasser commented Apr 2, 2020

🐒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants