Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struggling to trigger FileNotFound Error in get_github_auth() #468

Open
lwasser opened this issue Nov 24, 2021 · 1 comment
Open

Struggling to trigger FileNotFound Error in get_github_auth() #468

lwasser opened this issue Nov 24, 2021 · 1 comment

Comments

@lwasser
Copy link

lwasser commented Nov 24, 2021

I can't figure out how to trigger the filenotfound error in the get_github_auth() function.

see discussion here:

I just haven't been able to trigger it no matter what i try so i'd like to talk that through. i can revisit it later but it's an issue impacting pr #462

@lwasser lwasser changed the title Struggling to trigger FileNotFound Error Struggling to trigger FileNotFound Error in get_github_auth() Nov 24, 2021
@kcranston
Copy link
Collaborator

I think that this particular check is not necessary. It was written to catch the case where a user does not have a openssh installed. Instead, the installation instructions should be clear about what system dependencies are needed and we should not check for these in the code (i.e. we don't check that someone has git installed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants