Add tests of the getters and setters

Author: henrikjacobsenfys

src/easydynamics/sample_model/components/voigt.py

@@ -143,7 +143,7 @@ def gaussian_width(self, value: Numeric):
         """Set the gaussian_width parameter."""
         if not isinstance(value, Numeric):
             raise TypeError("width must be a number.")
-        self._width.value = float(value)
+        self._gaussian_width.value = float(value)
 
     @property
     def lorentzian_width(self) -> Parameter:

tests/unit_tests/sample_model/components/test_delta_function.py

@@ -1,7 +1,6 @@
 import pytest
 
 import numpy as np
-from scipp import UnitError
 
 from easydynamics.sample_model import DeltaFunction
 from easyscience.variable import Parameter
@@ -40,6 +39,31 @@ def test_negative_area_warns(self):
         with pytest.warns(UserWarning, match="may not be physically meaningful"):
             DeltaFunction(name="TestDeltaFunction", area=-2.0, center=0.5, unit="meV")
 
+    def test_area_property_getter(self, delta_function: DeltaFunction):
+        assert delta_function.area.value == 2.0
+
+    def test_area_property_setter(self, delta_function: DeltaFunction):
+        # WHEN
+        delta_function.area = 3.0
+
+        # THEN EXPECT
+        assert delta_function.area.value == 3.0
+        with pytest.raises(TypeError, match="area must be a number."):
+            delta_function.area = "invalid"
+
+    def test_center_property_getter(self, delta_function: DeltaFunction):
+        # WHEN THEN EXPECT
+        assert delta_function.center.value == 0.5
+
+    def test_center_property_setter(self, delta_function: DeltaFunction):
+        # WHEN
+        delta_function.center = 0.6
+
+        # THEN EXPECT
+        assert delta_function.center.value == 0.6
+        with pytest.raises(TypeError, match="center must be a number."):
+            delta_function.center = "invalid"
+
     @pytest.mark.xfail(
         reason="DeltaFunction.evaluate is not implemented yet without resolution convolution"
     )

tests/unit_tests/sample_model/components/test_gaussian.py

@@ -64,6 +64,7 @@ def test_area_property_setter(self, gaussian: Gaussian):
             gaussian.area = "invalid"
 
     def test_center_property_getter(self, gaussian: Gaussian):
+        # WHEN THEN EXPECT
         assert gaussian.center.value == 0.5
 
     def test_center_property_setter(self, gaussian: Gaussian):

tests/unit_tests/sample_model/components/test_lorentzian.py

@@ -57,6 +57,43 @@ def test_negative_area_warns(self):
                 name="TestLorentzian", area=-2.0, center=0.5, width=0.6, unit="meV"
             )
 
+    def test_area_property_getter(self, lorentzian: Lorentzian):
+        assert lorentzian.area.value == 2.0
+
+    def test_area_property_setter(self, lorentzian: Lorentzian):
+        # WHEN
+        lorentzian.area = 3.0
+
+        # THEN EXPECT
+        assert lorentzian.area.value == 3.0
+        with pytest.raises(TypeError, match="area must be a number."):
+            lorentzian.area = "invalid"
+
+    def test_center_property_getter(self, lorentzian: Lorentzian):
+        # WHEN THEN EXPECT
+        assert lorentzian.center.value == 0.5
+
+    def test_center_property_setter(self, lorentzian: Lorentzian):
+        # WHEN
+        lorentzian.center = 0.6
+
+        # THEN EXPECT
+        assert lorentzian.center.value == 0.6
+        with pytest.raises(TypeError, match="center must be a number."):
+            lorentzian.center = "invalid"
+
+    def test_width_property_getter(self, lorentzian: Lorentzian):
+        assert lorentzian.width.value == 0.6
+
+    def test_width_property_setter(self, lorentzian: Lorentzian):
+        # WHEN
+        lorentzian.width = 0.7
+
+        # THEN EXPECT
+        assert lorentzian.width.value == 0.7
+        with pytest.raises(TypeError, match="width must be a number."):
+            lorentzian.width = "invalid"
+
     def test_evaluate(self, lorentzian: Lorentzian):
         # WHEN
         x = np.array([0.0, 0.5, 1.0])

tests/unit_tests/sample_model/components/test_voigt.py

@@ -12,6 +12,8 @@
 
 from scipy.special import voigt_profile
 
+from easydynamics.sample_model.components.lorentzian import Lorentzian
+
 
 class TestVoigt:
     @pytest.fixture
@@ -123,6 +125,56 @@ def test_negative_area_warns(self):
                 unit="meV",
             )
 
+    def test_area_property_getter(self, voigt: Voigt):
+        assert voigt.area.value == 2.0
+
+    def test_area_property_setter(self, voigt: Voigt):
+        # WHEN
+        voigt.area = 3.0
+
+        # THEN EXPECT
+        assert voigt.area.value == 3.0
+        with pytest.raises(TypeError, match="area must be a number."):
+            voigt.area = "invalid"
+
+    def test_center_property_getter(self, voigt: Voigt):
+        # WHEN THEN EXPECT
+        assert voigt.center.value == 0.5
+
+    def test_center_property_setter(self, voigt: Voigt):
+        # WHEN
+        voigt.center = 0.6
+
+        # THEN EXPECT
+        assert voigt.center.value == 0.6
+        with pytest.raises(TypeError, match="center must be a number."):
+            voigt.center = "invalid"
+
+    def test_gaussian_width_property_getter(self, voigt: Voigt):
+        # WHEN THEN EXPECT
+        assert voigt.gaussian_width.value == 0.6
+
+    def test_gaussian_width_property_setter(self, voigt: Voigt):
+        # WHEN
+        voigt.gaussian_width = 0.7
+
+        # THEN EXPECT
+        assert voigt.gaussian_width.value == 0.7
+
+    def test_lorentzian_width_property_getter(self, voigt: Voigt):
+        # WHEN THEN EXPECT
+        assert voigt.lorentzian_width.value == 0.7
+
+    def test_lorentzian_width_property_setter(self, voigt: Voigt):
+        # WHEN
+        voigt.lorentzian_width = 0.8
+
+        # THEN EXPECT
+        assert voigt.lorentzian_width.value == 0.8
+
+        with pytest.raises(TypeError, match="width must be a number."):
+            voigt.lorentzian_width = "invalid"
+
     def test_evaluate(self, voigt: Voigt):
         # WHEN
         x = np.array([0.0, 0.5, 1.0])