From 6114f44ece1827b0245c62a38a95ef6fd06742a5 Mon Sep 17 00:00:00 2001 From: "Mattan S. Ben-Shachar" <35330040+mattansb@users.noreply.github.com> Date: Mon, 1 Apr 2024 10:58:24 +0300 Subject: [PATCH 1/4] prep for CRAN 0.8.7 (#634) * prep for CRAN * spelling * Update cran-comments.md --- DESCRIPTION | 10 +++++----- NEWS.md | 14 ++++---------- R/utils_validate_input_data.R | 2 +- cran-comments.md | 2 +- inst/WORDLIST | 17 +++++++++++------ man/RCT_table.Rd | 2 +- man/Smoking_FASD.Rd | 2 +- man/effectsize-package.Rd | 1 - man/food_class.Rd | 2 +- man/hardlyworking.Rd | 2 +- man/rouder2016.Rd | 2 +- man/screening_test.Rd | 2 +- vignettes/statistical_power.Rmd | 4 ++-- 13 files changed, 30 insertions(+), 32 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 38597d41..ad5a8302 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Type: Package Package: effectsize Title: Indices of Effect Size -Version: 0.8.6.6 +Version: 0.8.7 Authors@R: c(person(given = "Mattan S.", family = "Ben-Shachar", @@ -72,9 +72,9 @@ Depends: R (>= 3.6) Imports: bayestestR (>= 0.13.2), - insight (>= 0.19.8), - parameters (>= 0.21.5), - performance (>= 0.10.9), + insight (>= 0.19.9), + parameters (>= 0.21.6), + performance (>= 0.11.0), datawizard (>= 0.9.1), stats, utils @@ -105,7 +105,7 @@ VignetteBuilder: Encoding: UTF-8 Language: en-US Roxygen: list(markdown = TRUE) -RoxygenNote: 7.2.3.9000 +RoxygenNote: 7.3.1 Config/testthat/edition: 3 Config/testthat/parallel: true Config/Needs/website: diff --git a/NEWS.md b/NEWS.md index 8fe69bac..4fb1b81f 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,25 +1,19 @@ -# effectsize 0.8.7.xxx +# effectsize 0.8.7 - This release changes the licensing model of `{effectsize}` to an MIT license. ## New features -- `cohens_d()` and `glass_delta()` gain an `adjust` argument for applying Hedges' small-sample bias correction (`hedges_g()` is now an alias for `cohens_d(adjust = TRUE)`). - +- `cohens_d()` and `glass_delta()` gain an `adjust` argument for applying Hedges' small-sample bias correction (`hedges_g()` is now an alias for `cohens_d(adjust = TRUE)`). - `repeated_measures_d()` to compute standardized mean differences (SMD) for repeated measures data. - - Also supported in `effectsize()` + - Also supported in `effectsize()` +- New function: `interpret_fei()` ## Bug fixes - Minor stability fix to ncp-based CI methods ( #628 ) - `nnt()` now properly accepts the `y` argument. -# effectsize 0.8.7 - -## New features - -- New function: `interpret_fei()` - # effectsize 0.8.6 This is a minor update to bring `effectsize` in-line with the formula methods diff --git a/R/utils_validate_input_data.R b/R/utils_validate_input_data.R index 0aa5e2f1..089d702a 100644 --- a/R/utils_validate_input_data.R +++ b/R/utils_validate_input_data.R @@ -12,7 +12,7 @@ if (length(x) != 3L) { insight::format_error( "Formula must have one of the following forms:", - " y ~ group (independant samples)", + " y ~ group (independent samples)", " y ~ 1 (one sample)", " Pair(x,y) ~ 1 (paired samples)" ) diff --git a/cran-comments.md b/cran-comments.md index 24b7a9cf..1e4601ce 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -6,7 +6,7 @@ ## Test environments -* local installation: R 4.3.1 on Windows +* local installation: R 4.3.2 on Windows * GitHub Actions - Windows: release - macOS: release diff --git a/inst/WORDLIST b/inst/WORDLIST index a02cc55d..15aff426 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -49,7 +49,6 @@ Falk Faraggi Fei Fo -Fum Funder GFI Gelman @@ -82,8 +81,6 @@ Kiesser Koo Kruschke LMM -Labelled -labelled Lajeunesse Lakens Landis @@ -126,6 +123,7 @@ Penfield PloS Psychometrika Psychonomic +Pustejovsky RFI RMR RMSEA @@ -137,17 +135,21 @@ Ringle Rosenthal Rothstein Rouder +Rouder's Routledge Ruscio SDs SEM +SMD SRMR Sarstedt Sawilowsky Schumacker Schweder Shachar +Shadish Shmekels +Speckman Steiger Szodorai Szumilas @@ -172,6 +174,7 @@ anova arXiv arcsin biserial +blogspot bmwiernik brglm brms @@ -189,21 +192,24 @@ doi dynamicfit easystats effectSize +effectsize’ et fixest frac friedman ggstatsplot -github glmmadmb gtsummary homoscedasticity +http https +independant infty intraclass -io +jeffrouder joss kruskal +labelled lifecycle lm mattansb @@ -233,7 +239,6 @@ rescale rmANOVA sd semipartial -shinyapps statswiki strengejacke th diff --git a/man/RCT_table.Rd b/man/RCT_table.Rd index bf1e7426..8cad2ccf 100644 --- a/man/RCT_table.Rd +++ b/man/RCT_table.Rd @@ -20,8 +20,8 @@ Fictional Results from a Workers' Randomized Control Trial } \seealso{ Other effect size datasets: -\code{\link{Music_preferences2}}, \code{\link{Music_preferences}}, +\code{\link{Music_preferences2}}, \code{\link{Smoking_FASD}}, \code{\link{food_class}}, \code{\link{hardlyworking}}, diff --git a/man/Smoking_FASD.Rd b/man/Smoking_FASD.Rd index ec24a35f..eee90e58 100644 --- a/man/Smoking_FASD.Rd +++ b/man/Smoking_FASD.Rd @@ -18,8 +18,8 @@ Fictional data. } \seealso{ Other effect size datasets: -\code{\link{Music_preferences2}}, \code{\link{Music_preferences}}, +\code{\link{Music_preferences2}}, \code{\link{RCT_table}}, \code{\link{food_class}}, \code{\link{hardlyworking}}, diff --git a/man/effectsize-package.Rd b/man/effectsize-package.Rd index 6cd2eb23..128f4fa5 100644 --- a/man/effectsize-package.Rd +++ b/man/effectsize-package.Rd @@ -3,7 +3,6 @@ \docType{package} \name{effectsize-package} \alias{effectsize-package} -\alias{_PACKAGE} \title{effectsize: Indices of Effect Size} \description{ In both theoretical and applied research, it is often of interest to assess diff --git a/man/food_class.Rd b/man/food_class.Rd index 1bc5576e..eae288fa 100644 --- a/man/food_class.Rd +++ b/man/food_class.Rd @@ -19,8 +19,8 @@ Fictional data. } \seealso{ Other effect size datasets: -\code{\link{Music_preferences2}}, \code{\link{Music_preferences}}, +\code{\link{Music_preferences2}}, \code{\link{RCT_table}}, \code{\link{Smoking_FASD}}, \code{\link{hardlyworking}}, diff --git a/man/hardlyworking.Rd b/man/hardlyworking.Rd index 5dbd4572..0bf4714b 100644 --- a/man/hardlyworking.Rd +++ b/man/hardlyworking.Rd @@ -30,8 +30,8 @@ A sample (simulated) dataset, used in tests and some examples. } \seealso{ Other effect size datasets: -\code{\link{Music_preferences2}}, \code{\link{Music_preferences}}, +\code{\link{Music_preferences2}}, \code{\link{RCT_table}}, \code{\link{Smoking_FASD}}, \code{\link{food_class}}, diff --git a/man/rouder2016.Rd b/man/rouder2016.Rd index 866741c0..7a990608 100644 --- a/man/rouder2016.Rd +++ b/man/rouder2016.Rd @@ -31,8 +31,8 @@ The data is used in examples and tests of \code{\link[=rm_d]{rm_d()}}. } \seealso{ Other effect size datasets: -\code{\link{Music_preferences2}}, \code{\link{Music_preferences}}, +\code{\link{Music_preferences2}}, \code{\link{RCT_table}}, \code{\link{Smoking_FASD}}, \code{\link{food_class}}, diff --git a/man/screening_test.Rd b/man/screening_test.Rd index 7b3b0a67..4cbb1228 100644 --- a/man/screening_test.Rd +++ b/man/screening_test.Rd @@ -27,8 +27,8 @@ A sample (simulated) dataset, used in tests and some examples. } \seealso{ Other effect size datasets: -\code{\link{Music_preferences2}}, \code{\link{Music_preferences}}, +\code{\link{Music_preferences2}}, \code{\link{RCT_table}}, \code{\link{Smoking_FASD}}, \code{\link{food_class}}, diff --git a/vignettes/statistical_power.Rmd b/vignettes/statistical_power.Rmd index c28c5179..499162e9 100644 --- a/vignettes/statistical_power.Rmd +++ b/vignettes/statistical_power.Rmd @@ -79,7 +79,7 @@ So this is where we focus in this vignette, and pay special attention to the eas The following section walks through a simple applied example to ensure 1) the concepts surrounding and involved in power are clear and digestible, and 2) that the role and value of the `effectsize` package are likewise clear and digestible. Understanding both of these realities will allow for more complex extensions and applications to a wide array of research problems and questions. -# Example: Comparing Means of Independant Samples +# Example: Comparing Means of Independent Samples In addition to relying on the _easystats_ `effectsize` package for effect size calculation, we will also leverage the simple, but excellent `pwr` package for the following implementation of power analysis [@champley2017]. @@ -164,7 +164,7 @@ Given the prevalence of calculating effect sizes for different applications and There are many conversions available in the package. Take a look [here](https://easystats.github.io/effectsize/reference/index.html#effect-size-conversion). -This can also be dne directly by the user using the `t_to_d()` function: +This can also be done directly by the user using the `t_to_d()` function: ```{r} t_to_d( From 7c85fdfa788903312094922108578538493f5a1b Mon Sep 17 00:00:00 2001 From: Indrajeet Patil Date: Mon, 1 Apr 2024 20:08:13 +0200 Subject: [PATCH 2/4] Delete R-CMD-check-strict.yaml --- .github/workflows/R-CMD-check-strict.yaml | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 .github/workflows/R-CMD-check-strict.yaml diff --git a/.github/workflows/R-CMD-check-strict.yaml b/.github/workflows/R-CMD-check-strict.yaml deleted file mode 100644 index 5f84492d..00000000 --- a/.github/workflows/R-CMD-check-strict.yaml +++ /dev/null @@ -1,15 +0,0 @@ -# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples -# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help -# -# R CMD Check will fail on a `NOTE`. -on: - push: - branches: [main, master] - pull_request: - branches: [main, master] - -name: R-CMD-check-strict - -jobs: - R-CMD-check-strict: - uses: easystats/workflows/.github/workflows/R-CMD-check-strict.yaml@main From aa4a00b97a51714b282c2540c63c50ea767bea5c Mon Sep 17 00:00:00 2001 From: "Mattan S. Ben-Shachar" Date: Wed, 3 Apr 2024 03:37:32 +0300 Subject: [PATCH 3/4] fix #636 --- NEWS.md | 6 ++++++ R/cohens_d.R | 2 +- R/common_language.R | 5 +++-- R/rank_diff.R | 2 +- 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/NEWS.md b/NEWS.md index 4fb1b81f..fabab974 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,9 @@ +# effectsize 0.8.7.x + +## Bug fixes + +- `hedges_g()`, `vd_a()`, `wmw_odds()`, and `cliffs_delta()` no longer require `{effectsize}` to be loaded to work ( #636 ). + # effectsize 0.8.7 - This release changes the licensing model of `{effectsize}` to an MIT license. diff --git a/R/cohens_d.R b/R/cohens_d.R index 617e7c65..ec98162b 100644 --- a/R/cohens_d.R +++ b/R/cohens_d.R @@ -160,7 +160,7 @@ hedges_g <- function(x, y = NULL, data = NULL, ci = 0.95, alternative = "two.sided", verbose = TRUE, ...) { cl <- match.call() - cl[[1]] <- quote(cohens_d) + cl[[1]] <- quote(effectsize::cohens_d) cl$adjust <- TRUE eval.parent(cl) } diff --git a/R/common_language.R b/R/common_language.R index 392c094a..49dd1aa1 100644 --- a/R/common_language.R +++ b/R/common_language.R @@ -340,7 +340,7 @@ vd_a <- function(x, y = NULL, data = NULL, ci = 0.95, alternative = "two.sided", verbose = TRUE, ...) { cl <- match.call() - cl[[1]] <- quote(p_superiority) + cl[[1]] <- quote(effectsize::p_superiority) cl$parametric <- FALSE eval.parent(cl) } @@ -353,7 +353,7 @@ wmw_odds <- function(x, y = NULL, data = NULL, ci = 0.95, alternative = "two.sided", verbose = TRUE, ...) { cl <- match.call() - cl[[1]] <- quote(rank_biserial) + cl[[1]] <- quote(effectsize::rank_biserial) out <- eval.parent(cl) rb_to_wmw_odds(out) @@ -362,6 +362,7 @@ wmw_odds <- function(x, y = NULL, data = NULL, + # Utils ------------------------------------------------------------------- #' @keywords internal diff --git a/R/rank_diff.R b/R/rank_diff.R index c1a58ae7..7d7c1e98 100644 --- a/R/rank_diff.R +++ b/R/rank_diff.R @@ -220,7 +220,7 @@ cliffs_delta <- function(x, y = NULL, data = NULL, insight::format_error("This effect size is only applicable for two independent samples.") } - cl[[1]] <- quote(rank_biserial) + cl[[1]] <- quote(effectsize::rank_biserial) cl$x <- x cl$y <- y eval.parent(cl) From 16d832b3a56e71547732cbd2c851eed66d9f6344 Mon Sep 17 00:00:00 2001 From: "Mattan S. Ben-Shachar" Date: Wed, 3 Apr 2024 03:38:32 +0300 Subject: [PATCH 4/4] Update DESCRIPTION --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index ad5a8302..b77d2839 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Type: Package Package: effectsize Title: Indices of Effect Size -Version: 0.8.7 +Version: 0.8.7.1 Authors@R: c(person(given = "Mattan S.", family = "Ben-Shachar",