From db9190e13af680cf6d17da7f93b41b10be5fd467 Mon Sep 17 00:00:00 2001 From: Elliot Gould Date: Mon, 4 Sep 2023 15:57:25 +1000 Subject: [PATCH 1/3] Add method for parsnip _glm model --- R/check_convergence.R | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/R/check_convergence.R b/R/check_convergence.R index f86bff381..8472b8770 100644 --- a/R/check_convergence.R +++ b/R/check_convergence.R @@ -107,3 +107,8 @@ check_convergence.glmmTMB <- function(x, ...) { # https://github.com/glmmTMB/glmmTMB/issues/275 isTRUE(x$sdr$pdHess) } + +#' @export +check_convergence._glm <- function(x, ...){ + isTRUE(x$fit$converged) +} From 694c46fb85111e3b7fa725a35674250bcbcc7420 Mon Sep 17 00:00:00 2001 From: Daniel Date: Sun, 10 Sep 2023 20:27:45 +0200 Subject: [PATCH 2/3] Update NAMESPACE --- NAMESPACE | 1 + R/check_convergence.R | 1 + 2 files changed, 2 insertions(+) diff --git a/NAMESPACE b/NAMESPACE index 3479f911a..b5c3ee92b 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -45,6 +45,7 @@ S3method(check_collinearity,probitmfx) S3method(check_collinearity,zerocount) S3method(check_collinearity,zeroinfl) S3method(check_concurvity,gam) +S3method(check_convergence,"_glm") S3method(check_convergence,default) S3method(check_convergence,glmmTMB) S3method(check_convergence,merMod) diff --git a/R/check_convergence.R b/R/check_convergence.R index 8472b8770..87e16b5a0 100644 --- a/R/check_convergence.R +++ b/R/check_convergence.R @@ -108,6 +108,7 @@ check_convergence.glmmTMB <- function(x, ...) { isTRUE(x$sdr$pdHess) } + #' @export check_convergence._glm <- function(x, ...){ isTRUE(x$fit$converged) From 75e65adc88590ef3880d436467461d0bfa750840 Mon Sep 17 00:00:00 2001 From: Daniel Date: Sun, 10 Sep 2023 20:27:59 +0200 Subject: [PATCH 3/3] lintr --- R/check_convergence.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/check_convergence.R b/R/check_convergence.R index 87e16b5a0..06d0428a0 100644 --- a/R/check_convergence.R +++ b/R/check_convergence.R @@ -110,6 +110,6 @@ check_convergence.glmmTMB <- function(x, ...) { #' @export -check_convergence._glm <- function(x, ...){ +check_convergence._glm <- function(x, ...) { isTRUE(x$fit$converged) }