Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the expaned black bar #138

Open
alfonsomunozpomer opened this issue May 23, 2018 · 4 comments
Open

Add support for the expaned black bar #138

alfonsomunozpomer opened this issue May 23, 2018 · 4 comments

Comments

@alfonsomunozpomer
Copy link

I can see in

barContents.innerHTML = '<nav class="row">'+
that #masthead-black-bar is wrapped in a row div. I think that adding support for #masthead-black-bar-expanded would be simple enough. I can do a PR if you want.

From a personal standpoint I’m not a big supporter of the expanded layout, but we use it in Expression Atlas.

@khawkins98
Copy link
Contributor

So the idea is to use expand the masthead black bar when the content has also been expanded?

I guess this does look a little silly:
image

For discussion, what if you didn't expand all of the page (dropping .expanded from the intro text and local masthead; like this:

image

How does that feel?

(Trying to see if we don't have to add documentation for how and when to expand the global masthead)

@alfonsomunozpomer
Copy link
Author

To be honest, I don’t like it that much, but I’ll show it around my team to see what everybody thinks. I think expanding the black bar looks better and gives the page a more balanced look:
image

@khawkins98
Copy link
Contributor

khawkins98 commented May 25, 2018

I get that having the header and intro text centred atop the 100% width feels like an unbalanced pyramid. But I'm also thinking about the homepage where that intro text caaannnn geeeettttt awfullllly wiiiiiide -- certainly it's not an optimal line length for readability.

We could add some responsive classes to complement small- medium- large- (1200px), like: xlarge- (1400px) and xxlarge- (1800px)

Which would allow something like (xxlarge-6):
image

Useful?

@alfonsomunozpomer
Copy link
Author

I don’t want to be picky, but we’re now discussing a different issue altogether. As I said I’m not a big fan of the expanded layout myself, but before redesigning or changing the layout of our site, I was asking what seems a simple alternative style for the black bar.

As a sidenote, I’ve noticed that certain views in GitHub itself use such a thing:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants