Foundation tooltips broken on hover

[khawkins98]

As discovered by @esanzgar , Foundation's tooltips are busted in v1.3 when using the minified CSS.

This appears to be a byproduct of how csso compresses the CSS.

[khawkins98]

I've tried

-    "csso": "^2.1.1",
+    "csso": "^3.5.1",

But it doesn't seem to improve, investigating further.

[khawkins98]

Looks like if we use the --no-restructure option it prevents the optimisation that results in the bug.

Compression diff:

• Before: 114 575 bytes (over the wire compressed: 19.4KB)
• After: 119 286 bytes (over the wire compressed: 19.5KB)

5KB is probably a reasonable difference. I'll commit and we can debate about releasing to prod/test further.

https://dev.ebi.emblstatic.net/web_guidelines/EBI-Framework/v1.3/css/ebi-global.min.css

[esanzgar]

I was about to file an issue with csso, but found many related issues with the structural optimization. I am surprised we haven't found issues earlier.

Anyway, this is our issue with the reordering:

Before optimisation
After optimisation

[khawkins98]

Oof, well good that we've turned if off. Surprised it defaults to on.

[esanzgar]

Oof, well good that we've turned if off. Surprised it defaults to on.

Well, if no body else seem to notice... then maybe we should keep it on. It is a nice compression.

(My guess is that people notice but don't raise any issue, and they apply local patches.)