Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS modules compatibility #147

Open
BurkovBA opened this issue Jun 6, 2019 · 2 comments
Open

CSS modules compatibility #147

BurkovBA opened this issue Jun 6, 2019 · 2 comments

Comments

@BurkovBA
Copy link

BurkovBA commented Jun 6, 2019

Hi, Ken!

I'm trying to create an embeddable component for RNAcentral sequence search to be plugged-in into member databases websites.

I want the component to be styled in EBI theme 1.3, but at the same time I don't want it to break the host websites.

I was trying to use CSS modules and Webpack to import styles from your CSS files of ebi-global.css and theme-light.css and it would've worked just fine, but unfortunately your css files also contain global style definitions, such as h1 etc. They would interfere with the host CSS.

So, I believe, I'll have to go with shadow DOM.

I'm wondering: did you consider making EBI Framework compatible with CSS modules? Maybe, splitting the SASS styles into global and local ones?

Thanks,
Boris

@khawkins98
Copy link
Contributor

Hi Boris.

Good timing! I'll be at EBI Day (Thursday the 13th; poster 15) talking about how we're addressing this.

It's (obviously) a major change and one that is at the heart of the next version of the Visual Framework.

We should have a couple of specific demos available for Thursday too.

@BurkovBA
Copy link
Author

BurkovBA commented Jun 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants