-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are there upstream interests in continuing to maintain this repository or is it feature-complete ? #427
Comments
I don't think this is able to be feature complete any time soon, aside from bumping dependencies, unless the LSP specification is going to be. I have interest in keeping it alive, and this is already a couple of versions behind |
@idealseal do you intend to publish your fork? We're actively using this crate but can't take a git dependency unfortunately. |
@trevor-scheer |
@TilakMaddy I think it's rather a policy on their side. In any other case, |
@trevor-scheer I thought I will give @ebkalderon a little time, but I can publish the fork if there is interest already. |
@idealseal thanks, we can wait a bit 👍 @TilakMaddy we publish to crates.io so can't have git dependencies. |
Any ideas for a library name? Otherwise I would go for something like |
@idealseal that seems fine. I can't think of anything better that isn't a joke ( I've sent Eyal an email, perhaps we wait til next week? No urgency on my end. I'm hoping that if he's not interested in maintaining that maybe he would enable others to 🤞 |
That's an amazing name, I need more of that sort. I will think about it 😆 |
|
I'm off to my wedding and honeymoon for ~ a month so won't be too responsive if at all. I haven't received a response to my email yet unfortunately. There is still no urgency for this on my end though. My colleague @Jephuff will follow along for updates. Just as a consideration for your own efforts, if it's got to be forked, it's possible we'll need to maintain our own in the long term. |
We're using this crate as well for https://github.com/Cyfrin/aderyn would love to chime in and support when I can ! |
I feel I must say that this seems backwards from the way things are normally done, make a bunch of PRs and then if those don't get merged, consider forking. |
@ratmice I think a good faith effort is being made here. This issue is 2mos old with no response from the maintainer. We're making legitimate efforts to avoid forking if possible and I've reached out to him directly. It's true there aren't open PRs for the dependency updates but given the lack of response so far, I wouldn't expect those to be answered either. |
@trevor-scheer My main concern is that the user proposing forking is not following the typical process of making PRs themself before forking, along with the account proposing to fork only being a month old, newer than this issue itself! While everyone must start somewhere, I do find it hard not to be skeptical. LSPs could make for an attractive target for some purposes, and no one is going to make it obvious they are making a bad faith effort. The above 2 things are enough for me to nope out on this proposed fork well intended as it might be. |
Maybe make an organization for There was a similar problem for |
@ratmice ah, I think your concerns about the potential for a bad actor are valid, admittedly that was not where I was coming from when I said "good faith". I'd be happy to create that GH org and add contributors if that's the route people want to go. I don't know that anything in particular qualifies me over someone else to admin the org/fork but I'd be happy to do it in the absence of anyone else who felt particularly motivated to. My interest in this project lies in the current work I do for Apollo Graph. An alternative option would be to find a relevant existing org to be the "host" if they're interested, i.e.:
|
I would also assist with maintenance and continued development here. |
I don't think I also need For the name : maybe |
Is there any conclusions? Has anyone got access to the author? |
@Decodetalkers No response from the author unfortunately. I'll be back from holiday near the end of November. At that point I'd be happy to create the org and fork if nobody else has by then. In any case I'd be happy to be involved as a maintainer or admin. |
|
have the name been decided? I want to start contribute to the fork. Do you need help now? |
Not yet, but you can join the relevant discussion tower-lsp/tower-lsp#3. |
No description provided.
The text was updated successfully, but these errors were encountered: