Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounding in sort column #184

Open
NickCEBM opened this issue Feb 28, 2019 · 0 comments · May be fixed by #193 or #197
Open

Rounding in sort column #184

NickCEBM opened this issue Feb 28, 2019 · 0 comments · May be fixed by #193 or #197

Comments

@NickCEBM
Copy link
Contributor

Not sure if this was intended behavior but, as outlined in this tweet, the percentage reported in the sorting column for a sponsor is always rounded down. For instance, University Of Chicago is at 42.9% reported but in the overall sponsor list, it is at 42% reported.

https://twitter.com/TranspariMED/status/1101123509412089857
chadmiller added a commit to chadmiller/clinicaltrials-act-tracker that referenced this issue Mar 27, 2019
@chadmiller
Drop computable Rankings.percentage and provide func
782ff5f 
At model instance .save() time, we were calculating the value of one column
using two others.

Since the type of that column is an IntegerField but elsewhere on the site we
round to one digit after decimal, a reader complained about the inconsistency
(really that it was a floor() operation).

Instead, this is the first part of the whole fix, but someone else can
"makemigrations" to discard the db column at leisure.

Closes ebmdatalab#184
@chadmiller chadmiller linked a pull request Mar 27, 2019 that will close this issue
Open
chadmiller referenced this issue in chadmiller/clinicaltrials-act-tracker May 1, 2019
@chadmiller
Make percentage a number and convert old values
954fc0a 
Also, don't stop processing percentage and leave old percentage when there are
currently no trials due.

Closes#184
@chadmiller chadmiller linked a pull request May 1, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@NickCEBM