Skip to content
This repository has been archived by the owner on Aug 9, 2018. It is now read-only.

Remove feature from SVG names #55

Open
gjjones opened this issue Feb 26, 2015 · 2 comments
Open

Remove feature from SVG names #55

gjjones opened this issue Feb 26, 2015 · 2 comments
Assignees
Milestone

Comments

@gjjones
Copy link
Contributor

gjjones commented Feb 26, 2015

I'm looking to start adding SVGs that serve the same purpose at other SVGs in edna. Using the current scheme, they would have the same names. Any thoughts on a better naming convention?

@gjjones
Copy link
Contributor Author

gjjones commented Feb 26, 2015

Naming based on their visual appearance seems like a better idea. It would involve less clashing, and naming of these files doesn't feel like it needs a purpose-based name(like transport-prev). Describing the display can be more lengthy too, so these might get ugly in CSS.

Example is arrow-slim-left vs transport-prev.

@wylie
Copy link

wylie commented Feb 26, 2015

We may want to do this as we implement GruntIcon 2.0 ( #45 ). Will need to look into inline SVGs a bit more. As we transition over these specific names might cause headaches when we bring these into the template.

@wylie wylie modified the milestones: Backlog, Test, GruntIcon Mar 6, 2015
@wylie wylie assigned wylie and gjjones and unassigned wylie Mar 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants