Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21.05 version of plugin does not start on Koha 21.05 #112

Open
ricofreak opened this issue Oct 6, 2021 · 5 comments
Open

21.05 version of plugin does not start on Koha 21.05 #112

ricofreak opened this issue Oct 6, 2021 · 5 comments

Comments

@ricofreak
Copy link

The 21.05 version of the plugin doesn't start in Koha version 21.05

It can be started by adding the following JS:

StartEDS('default')

But the plugin won't start on its own

@mmabrahamson
Copy link
Collaborator

Hello! I wanted to verify that a few things were done that might have resolved this:

  • The plugin was installed through the usual plugin installation method.
  • The configuration screen was accessed and saved (this should be done even if you are upgrading and the plugin was previously configured)
  • All data in the Configuration screen was filled in and there were no missing variables.
  • The plugin has permissions to create a JavaScript file in its own directories.

The javascript is created on save of the configuration data now in order to speed up load times for end users, so it must be opened and saved at least once after install.

@ricofreak
Copy link
Author

Thanks for the quick reply Micheal:

* The plugin was installed through the usual plugin installation method.

Yes, I installed the 21.05 KPZ via the normal Koha method.

* The configuration screen was accessed and saved (this should be done even if you are upgrading and the plugin was previously configured)

Yes, I did this.

* All data in the Configuration screen was filled in and there were no missing variables.

There are no missing variable and all the data was retained when the plugin was upgraded to the 21.05 version.

* The plugin has permissions to create a JavaScript file in its own directories.

It can, and I see that the plugin did add its own JavaScript on 10/6/2021 which was after I installed a 21.05 version.

@kidclamp
Copy link
Contributor

I do see some errors in the console:
Source map error: Error: request failed with status 404
Resource URL: https://widgets.ebscohost.com/prod/common/javascript/gss-common.js
Source Map URL: jquery-1.10.2.min.map
2

Permission denied to access property "document" on cross-origin object script_auth_id.js:174:23

Can confirm EDScript.js is updated when settings changed

@mmabrahamson
Copy link
Collaborator

Can we try a few things to check on this?

First, I just merged an update that fixes some known issues with linking in the 21.05 version. You can download it here: https://github.com/ebsco/edsapi-koha-plugin/blob/master/eds_plugin_21.05002.kpz

Try installing that version and then saving your configuration again.

If it doesn't work after that, can you make sure that there's no script enabled in the "run tool" section? We want to make sure that's empty to see if it's something custom causing the issue as we're unable to duplicate the issue locally so far.

If you're still seeing issues, I've got a potential PR that removes the file mentioned above. I don't think it's needed anymore:
https://github.com/ebsco/edsapi-koha-plugin/blob/remove-widgets-code/eds_plugin_21.05003.kpz

If it's still having issues loading, could you give a link to your Koha instance that we can test against?

@kidclamp
Copy link
Contributor

kidclamp commented Nov 3, 2021

The site in question is here:
https://galveston.bywatersolutions.com/

I have installed the 21.05003.kpz but the problems persist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants