Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate how costly is to remove PCRaster dependency #8

Closed
domeniconappo opened this issue Apr 10, 2019 · 1 comment
Closed

Evaluate how costly is to remove PCRaster dependency #8

domeniconappo opened this issue Apr 10, 2019 · 1 comment
Assignees
@domeniconappo
Labels
wontfix This will not be worked on

Comments

@domeniconappo
Copy link
Contributor

domeniconappo commented Apr 10, 2019 •
edited
Loading

related sub task: #7
@domeniconappo
Copy link
Contributor Author

In case of LISVAP, PCRaster is not strictly needed. So to remove this (huge) dependency we need to:

  1. port all array operations from pcraster to numpy
  2. Implement a simple framework to run the model (similar to PCRaster DynamiModelFramework)
  3. Remove all code where it reads a PCRaster map (we are 100% netcdf now) or, to keep the ability to read pcraster, just use a GDAL wrapper similar to this:
    https://github.com/ec-jrc/lisflood-utilities/blob/master/pcr2nc/pcr2nc/reader.py

@domeniconappo domeniconappo added the enhancement New feature or request label May 21, 2019
@domeniconappo domeniconappo self-assigned this May 21, 2019
@domeniconappo domeniconappo added wontfix This will not be worked on and removed enhancement New feature or request labels Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domeniconappo domeniconappo

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@domeniconappo