Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric signing_ops_total not incremented by operations not generic #376

Open
stephengaudet opened this issue Jun 12, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@stephengaudet
Copy link
Contributor

stephengaudet commented Jun 12, 2023

this behaviour exists on v.1.0.0-beta3 and so is not new.

non-generic operations are the baking operations { preendorsement, endorsement, block }
signing of non-generic operations increments metrics vault_sign_request_duration_milliseconds*, but, do not increment the signing_ops_total metric.
only generic operations increment the signing_ops_total metric. sharing the label op = "generic", these operations distinguish themselves with the label "kind" {transfer, reveal, ..etc}
generic operations also increment the metrics vault_sign_request_duration_milliseconds*. when doing so, they do not label for "kind", so, the vault_sign_request_duration_milliseconds* metrics whose op = "generic" do not distinguish themselves by kind like signing_ops_total does.

steps to reproduce:
1.for address XYZ take note of the metrics values
2.do non-generic (baking) operation for address XYZ. observe metrics.
3.do generic (ex: transfer) operation for address XYZ. observe metrics.

expected:
with a name like signing_ops_total, signing any/all operations would update this metric

actual:
baking operations do not update signing_ops_total metric

@stephengaudet stephengaudet added the bug Something isn't working label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant