Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart_rollup_originate optional param whitelist #3021

Open
hui-an-yang opened this issue Aug 13, 2024 · 0 comments
Open

smart_rollup_originate optional param whitelist #3021

hui-an-yang opened this issue Aug 13, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@hui-an-yang
Copy link
Collaborator

The smart_rollup_originate operation now also takes an optional whitelist of public key hashes. This whitelist cannot be used yet (the sc_rollup.private_enable flag has to be set to true). (MR !9401)

This is from oxford2 changelog, we've added local forging support but didn't update our contractAPI. But I just checked private_enable is now true and activated on mainnet. We should also support user who wants to use smart_rollup_originate with the optional whitelist param.

The work includes updating rpc type SmartRollupOriginateParams to the entire contractAPI data flow(prepare, estimate), making sure whitelist param is carrying over to be forged, signed and injected.

Would be good to update unit/integration test and doc with the optional param, too

@hui-an-yang hui-an-yang added the enhancement New feature or request label Aug 13, 2024
@hui-an-yang hui-an-yang added this to the 20.1 milestone Aug 13, 2024
@hui-an-yang hui-an-yang modified the milestones: 20.1, 21, v21, v20.1 Oct 2, 2024
@hui-an-yang hui-an-yang modified the milestones: v20.1, NEXT Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

1 participant