<CR> on mini.completion

[kwagi]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.completion

Question

In documentary on ":h mini.completion",

  local keycode = vim.keycode or function(x)
    return vim.api.nvim_replace_termcodes(x, true, true, true)
  end
  local keys = {
    ['cr']        = keycode('<CR>'),
    ['ctrl-y']    = keycode('<C-y>'),
    ['ctrl-y_cr'] = keycode('<C-y><CR>'),
  }

  _G.cr_action = function()
    if vim.fn.pumvisible() ~= 0 then
      -- If popup is visible, confirm selected item or add new line otherwise
      local item_selected = vim.fn.complete_info()['selected'] ~= -1
      return item_selected and keys['ctrl-y'] or keys['ctrl-y_cr']
    else
      -- If popup is not visible, use plain `<CR>`. You might want to customize
      -- according to other plugins. For example, to use 'mini.pairs', replace
      -- next line with `return require('mini.pairs').cr()`
      return keys['cr']
    end
  end

  vim.keymap.set('i', '<CR>', 'v:lua._G.cr_action()', { expr = true })

And it says,
If popup is visible, confirm selected item or add new line otherwise

I followed this steps with copy-and-paste this.

But "Enter" key does normal "" consistently. No select suggested.

Am i missing something?

[echasnovski]

I followed this steps with copy-and-paste this.

But "Enter" key does normal "<CR>" consistently. No select suggested.

Sorry, I don't really understand the issue. Would you mind elaborating a bit? Ideally, record a screencast of the behavior and post it here.

Also, make sure that <CR> Insert mode mapping is not overridden with something else. For example, by 'mini.pairs'. To do that, execute :imap <CR> and confirm that it shows v:lua._G.cr_action() (and not something like v:lua.MiniPairs.cr()). In case it does, take a look in the comment of the pasted code from 'mini.completion' help, and use return MiniPairs.cr() (slightly better than require('mini.pairs').cr()) instead of return keys['cr'].

[echasnovski]

I expected "CR" key does confirm the suggested keyword(or function..etc) when suggestion box is visible.

To do that, the item should be selected. By default, it means that user should press <C-n> / <C-p> at least once after suggestion box appears automatically. And "confirm" here means simply that suggestion box disappears.

[kwagi]

For example,

1. I typed 'f'

f|
 ^
-- '^' is cursor location.

2. The plugin suggested me "false" keyword, So i select with C-n

false|
     ^

3. And i accept this suggestion with stroke "CR"

false
|
^

But it does move to next line.

I expected on step(3)

false|
     ^

[echasnovski]

Yes, what you expect should indeed happen. Here is the demo of how it should behave (including the case of when it should add new line and the output of :imap <CR>):

minicompletion-cr.mp4

Please, check :imap <CR> output.

[kwagi]

I guess i found caused config.

when i enable "pair" module with require(mini.pairs).setup(), then output of :imap <CR> is

i <CR>  *v:lua._G.cr_action()
         Mini.Pairs <CR> 

And i disable with comment it -- require(mini.pairs).setup() , then output is

i <CR>  *v:lua._G.cr_action()

It only appears v:lua._G.cr_action()

I don't know how to configure mini.pairs and mini.completion at same time.

[echasnovski]

I don't know how to configure mini.pairs and mini.completion at same time.

Please, read this comment which has exact steps described. And those are also present in the code comment of 'mini.completion' help.

[kwagi]

I solved this with lazy-load "mini.pairs"