Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to hide columns #45

Closed
wants to merge 4 commits into from

Conversation

andy1uu
Copy link
Contributor

@andy1uu andy1uu commented Jun 22, 2023

No description provided.

@andy1uu andy1uu linked an issue Jun 22, 2023 that may be closed by this pull request
@andy1uu andy1uu self-assigned this Jun 22, 2023
@andy1uu andy1uu requested a review from maneshd August 26, 2023 17:26
@maneshd
Copy link
Contributor

maneshd commented Sep 19, 2023

This is great! Really nice functionality :) Aesthetics-wise, I think because it's front-and-center, it would be nice if we could make the row of buttons a little nicer looking.

I suggest:

  • Starting a new row every 5 buttons or so
  • Giving the option to show/hide the buttons (like this "collapse" example, but maybe from clicking a link instead of a button?)
  • Possibly making the "All" button different (link instead of button? Hollow button? Disable it when everything is selected already?)

@andy1uu andy1uu closed this Sep 26, 2023
@andy1uu andy1uu deleted the andyluu-36-hiding-rearranging-columns branch September 27, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding / Rearranging Columns
2 participants